Add complete codebase audit of all incomplete items

Comprehensive scan identifying: - 2 CRITICAL blocking issues (Discord CSP, SDK auth) - 7 HIGH priority unfinished features - 8 placeholder/stub pages - 49+ any type usages - 150+ debug console.log statements - 4 TODO comments - 5 mock data instances - 10+ "Coming Soon" UI elements Includes prioritized fix order and complete/incomplete summary.
2026-01-03 19:48:53 +00:00 · 2026-01-03 19:48:53 +00:00 · db37bfc733
commit db37bfc733
parent f29196363f
1 changed files with 287 additions and 0 deletions
--- a/docs/COMPLETE-CODEBASE-AUDIT.md
+++ b/docs/COMPLETE-CODEBASE-AUDIT.md
@ -0,0 +1,287 @@
+# Complete Codebase Audit - Everything Incomplete
+
+> **Generated:** 2026-01-03
+> **Scan Type:** Full codebase analysis
+
+---
+
+## Executive Summary
+
+| Category | Count | Severity |
+|----------|-------|----------|
+| Blocking Issues | 2 | CRITICAL |
+| Unfinished Features | 7 | HIGH |
+| Placeholder/Stub Pages | 8 | HIGH |
+| TODO Comments | 4 | MEDIUM |
+| Type Issues (`any`) | 49+ | MEDIUM |
+| Console.log (Debug) | 150+ | LOW |
+| Mock Data | 5 | LOW |
+| Coming Soon UI | 10+ | LOW |
+
+---
+
+## CRITICAL - Blocking Issues
+
+### 1. Discord Activity CSP Configuration
+- **File:** `vercel.json` line 47
+- **Problem:** `frame-ancestors 'none'` blocks Discord iframe embedding
+- **Fix Required:** Change to `frame-ancestors 'self' https://*.discordsays.com`
+- **Impact:** Discord Activity completely broken
+
+### 2. Discord SDK Authentication Missing
+- **File:** `client/contexts/DiscordActivityContext.tsx`
+- **Problem:** `discordSdk.commands.authenticate()` never called
+- **Fix Required:** Add SDK authentication call after ready
+- **Impact:** Discord SDK commands unavailable in Activity
+
+---
+
+## HIGH - Unfinished Features
+
+### 1. Email Verification Flow
+- **Status:** NOT IMPLEMENTED
+- **Files:** `server/email.ts`
+- **Missing:**
+  - Verification endpoint
+  - Email template
+  - Confirmation page
+  - Notification trigger
+
+### 2. Client Portal (`/hub/client`)
+- **Status:** ALL PLACEHOLDER PAGES
+- **Files:**
+  | File | Status |
+  |------|--------|
+  | `client/pages/hub/ClientInvoices.tsx` | Shows "Invoice tracking coming soon" |
+  | `client/pages/hub/ClientReports.tsx` | Shows "Detailed project reports coming soon" |
+  | `client/pages/hub/ClientContracts.tsx` | 56 lines - placeholder only |
+  | `client/pages/hub/ClientSettings.tsx` | 56 lines - placeholder only |
+  | `client/pages/hub/ClientProjects.tsx` | Uses mock data array |
+
+### 3. Mentorship System UI
+- **Status:** Database complete, UI incomplete
+- **Files:**
+  - `client/pages/community/MentorApply.tsx`
+  - `client/pages/community/MentorProfile.tsx`
+  - `client/pages/community/MentorshipRequest.tsx`
+  - `client/pages/MentorshipPrograms.tsx`
+- **Missing:** Enhanced UI for mentor profiles and requests
+
+### 4. Creator Network - Nexus Integration
+- **Status:** Basic directory only
+- **Files:**
+  - `client/pages/creators/CreatorDirectory.tsx`
+  - `client/pages/creators/CreatorProfile.tsx`
+  - `api/creators.ts`
+- **Missing:**
+  - Messaging system
+  - Contract management
+  - Payment processing
+  - 20% commission system
+
+### 5. Login/Onboarding Profile Handling
+- **Status:** Needs UX refinement
+- **Files:** `client/pages/Login.tsx`, `Dashboard.tsx`
+- **Issue:** Users shown as "logged in" before profile fully loads
+- **Documentation:** `docs/LOGIN-ONBOARDING-REDIRECT-ANALYSIS.md`
+
+### 6. Discord Activity Features
+- **Status:** WIP/Partial
+- **Files:**
+  - `client/pages/Activity.tsx`
+  - `client/pages/DiscordActivity.tsx`
+- **Notes:** Marked as WIP in tech stack docs
+
+### 7. Watcher Service Pipeline
+- **File:** `services/watcher.js` line 21
+- **TODO:** "Route safe content to renderer or local analysis pipeline"
+
+---
+
+## HIGH - Placeholder/Stub Pages
+
+| File | Lines | Description |
+|------|-------|-------------|
+| `client/pages/hub/ClientInvoices.tsx` | ~50 | "Invoice tracking coming soon" |
+| `client/pages/hub/ClientReports.tsx` | ~50 | "Project reports coming soon" |
+| `client/pages/hub/ClientContracts.tsx` | 56 | Back button + placeholder |
+| `client/pages/hub/ClientSettings.tsx` | 56 | Back button + placeholder |
+| `client/pages/Placeholder.tsx` | 101 | Generic "Under Construction" |
+| `client/pages/SignupRedirect.tsx` | 7 | Just redirects to login |
+| `client/pages/Index.tsx` | 20 | Basic home redirect |
+| `client/pages/LegacyPassportRedirect.tsx` | 50 | Legacy redirect handler |
+
+---
+
+## MEDIUM - TODO Comments
+
+| File | Line | TODO |
+|------|------|------|
+| `services/watcher.js` | 21 | Route safe content to renderer or local analysis pipeline |
+| `docs/USERNAME-FIRST-UUID-FALLBACK.md` | 275 | Migrate existing profiles without usernames to auto-generated |
+| `docs/USERNAME-FIRST-UUID-FALLBACK.md` | 276 | Add URL redirects for canonical username-based URLs |
+| `docs/USERNAME-FIRST-UUID-FALLBACK.md` | 277 | Update all link generation to prefer usernames |
+
+---
+
+## MEDIUM - Type Issues (Excessive `any`)
+
+**49+ instances across codebase:**
+
+| File | Count | Examples |
+|------|-------|----------|
+| `tests/creator-network-api.test.ts` | 7+ | `error?: any`, `body?: any` |
+| `tests/e2e-creator-network.test.ts` | 8+ | `any` in assertions |
+| `tests/performance.test.ts` | 2+ | API call types |
+| `server/supabase.ts` | 1 | `let admin: any = null` |
+| `server/index.ts` | 30+ | `as any` casts throughout |
+| `api/integrations/fourthwall.ts` | 9+ | `req: any, res: any` in handlers |
+
+---
+
+## MEDIUM - API Endpoints Returning 501
+
+| File | Line | Description |
+|------|------|-------------|
+| `api/_auth.ts` | 135 | Returns 501: "Not a handler" |
+| `api/_notifications.ts` | 47 | Returns 501: "Not a handler" |
+| `api/_supabase.ts` | 40 | Returns 501: "Not a handler" |
+| `api/opportunities.ts` | 319 | Returns 501: "Not a handler" |
+
+---
+
+## LOW - Console.log Statements (Debug Logging)
+
+**150+ instances - should be cleaned up for production:**
+
+| File | Count | Category |
+|------|-------|----------|
+| `server/index.ts` | 50+ | Auth and email flow logging |
+| `tests/error-handling.test.ts` | 30+ | Test output |
+| `tests/e2e-creator-network.test.ts` | 40+ | E2E test logging |
+| `electron/main.js` | 20+ | Electron app logging |
+| `api/integrations/fourthwall.ts` | 10+ | Integration logging |
+
+---
+
+## LOW - Mock Data in Production Code
+
+| File | Mock | Description |
+|------|------|-------------|
+| `client/lib/mock-auth.ts` | MockAuthService | Testing auth without Supabase |
+| `client/pages/hub/ClientProjects.tsx` | mockProjects | Hardcoded sample projects |
+| `server/index.ts:6872` | mockMembers | Hardcoded team members |
+| `client/pages/Activity.tsx:2852` | mockBadges, mockLevel, mockXP | Computed in useMemo |
+| `server/index.ts:2071` | Password field | Hard-coded "aethex-link" |
+
+---
+
+## LOW - "Coming Soon" UI Elements
+
+| File | Line | Element |
+|------|------|---------|
+| `client/pages/Dashboard.tsx` | 699, 706, 713 | 3x "Coming Soon" badges |
+| `client/pages/Downloads.tsx` | 128 | Downloadable client button |
+| `client/pages/staff/StaffInternalMarketplace.tsx` | 29, 81 | Service availability |
+| `client/pages/community/EthosGuild.tsx` | 80, 88, 104 | 3x guild items |
+| `client/pages/docs/DocsCurriculumEthos.tsx` | 730 | Curriculum badge |
+
+---
+
+## LOW - Environment Configuration Gaps
+
+| File | Issue |
+|------|-------|
+| `.env.example` | Only Supabase config - missing 20+ env vars for Discord, OAuth, Stripe |
+| `.env.discord.example` | Placeholder values like `your-discord-client-secret-here` |
+| `.env.foundation-oauth.example` | Secret key exposed in example |
+
+---
+
+## LOW - Disabled Features
+
+| File | Line | Feature | Reason |
+|------|------|---------|--------|
+| `electron/main.js` | 89 | Overlay window | "was blocking clicks on main window" |
+| `client/pages/staff/StaffInternalMarketplace.tsx` | 269-272 | Coming Soon services | Buttons disabled |
+
+---
+
+## LOW - Small/Minimal Pages
+
+| File | Lines | Notes |
+|------|-------|-------|
+| `client/pages/WixFaq.tsx` | 16 | Likely placeholder |
+| `client/pages/ArmFeeds.tsx` | 38 | Sparse implementation |
+| `client/pages/Wix.tsx` | 40 | Limited functionality |
+| `client/pages/DiscordOAuthCallback.tsx` | 44 | Callback redirect only |
+| `client/pages/WixCaseStudies.tsx` | 49 | Sparse content |
+
+---
+
+## Database Migrations
+
+**Status:** COMPLETE
+- 20 migration files present (Dec 2024 - Jan 2025)
+- No pending or incomplete migrations
+- Recent: Nexus Core, social invites/reputation, moderation reports
+
+---
+
+## Complete vs Incomplete Summary
+
+### What's Complete (Working)
+- Authentication flows (Discord OAuth, GitHub, Google, Email/Password)
+- User onboarding wizard (8 steps)
+- Notification system (20 types)
+- Discord bot commands (5 commands)
+- Opportunity posting/applications
+- GameForge project management
+- Team/Squad creation
+- Stripe payments/subscriptions
+- Ethos Guild (artist verification, track upload, licensing)
+- Staff/Admin workflows
+- Achievement/XP system
+- All database migrations
+
+### What's Incomplete (Needs Work)
+
+#### CRITICAL (2)
+1. Discord Activity CSP - BLOCKING
+2. Discord SDK Auth - INCOMPLETE
+
+#### HIGH PRIORITY (7)
+1. Email Verification - NOT IMPLEMENTED
+2. Client Portal - 5 PLACEHOLDER PAGES
+3. Mentorship UI - PARTIAL
+4. Creator Network Nexus - PARTIAL
+5. Login/Onboarding UX - NEEDS REFINEMENT
+6. Discord Activity Features - WIP
+7. Watcher Pipeline - TODO
+
+#### MEDIUM PRIORITY
+- 49+ `any` type usages
+- 4 API 501 endpoints
+- 4 TODO comments
+
+#### LOW PRIORITY
+- 150+ console.log statements
+- 5 mock data instances
+- 10+ "Coming Soon" UI elements
+- Environment config gaps
+- 5+ minimal placeholder pages
+
+---
+
+## Recommended Fix Order
+
+1. **CRITICAL:** Fix `vercel.json` CSP for Discord Activity
+2. **CRITICAL:** Add Discord SDK authentication
+3. **HIGH:** Implement email verification
+4. **HIGH:** Build out Client Portal pages
+5. **HIGH:** Complete Mentorship UI
+6. **HIGH:** Add Creator Network Nexus features
+7. **MEDIUM:** Replace `any` types with proper typing
+8. **MEDIUM:** Clean up debug logging
+9. **LOW:** Replace mock data with real implementations
+10. **LOW:** Complete "Coming Soon" features